Messages in this thread | | | Date | Tue, 21 Mar 2023 10:24:49 +0000 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH net v2 1/2] net: stmmac: fix PHY handle parsing |
| |
On Tue, Mar 21, 2023 at 08:34:49AM +0000, Sit, Michael Wei Hong wrote: > > > > -----Original Message----- > > From: Russell King <linux@armlinux.org.uk> > > Sent: Saturday, March 18, 2023 4:58 AM > > To: Andrew Lunn <andrew@lunn.ch> > > Cc: Sit, Michael Wei Hong <michael.wei.hong.sit@intel.com>; > > Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre > > Torgue <alexandre.torgue@foss.st.com>; Jose Abreu > > <joabreu@synopsys.com>; David S . Miller > > <davem@davemloft.net>; Eric Dumazet > > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; > > Paolo Abeni <pabeni@redhat.com>; Maxime Coquelin > > <mcoquelin.stm32@gmail.com>; Ong, Boon Leong > > <boon.leong.ong@intel.com>; netdev@vger.kernel.org; linux- > > stm32@st-md-mailman.stormreply.com; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Looi, > > Hong Aun <hong.aun.looi@intel.com>; Voon, Weifeng > > <weifeng.voon@intel.com>; Lai, Peter Jun Ann > > <peter.jun.ann.lai@intel.com> > > Subject: Re: [PATCH net v2 1/2] net: stmmac: fix PHY handle > > parsing > > > > On Fri, Mar 17, 2023 at 08:56:19PM +0100, Andrew Lunn wrote: > > > On Tue, Mar 14, 2023 at 03:02:07PM +0800, Michael Sit Wei > > Hong wrote: > > > > phylink_fwnode_phy_connect returns 0 when set to > > MLO_AN_INBAND. > > > > This causes the PHY handle parsing to skip and the PHY will not > > be > > > > attached to the MAC. > > > > > > Please could you expand the commit message because i'm > > having trouble > > > following this. > > > > > > phylink_fwnode_phy_connect() says: > > > > > > /* Fixed links and 802.3z are handled without needing a > > PHY */ > > > if (pl->cfg_link_an_mode == MLO_AN_FIXED || > > > (pl->cfg_link_an_mode == MLO_AN_INBAND && > > > phy_interface_mode_is_8023z(pl->link_interface))) > > > return 0; > > > > > > So your first statement is not true. It should be > > MLO_AN_INBAND and > > > phy_interface_mode_is_8023z. > > > > > > > Add additional check for PHY handle parsing when set to > > MLO_AN_INBAND. > > > > > > Looking at the patch, there is no reference to > > MLO_AN_INBAND, or > > > managed = "in-band-status"; > > > > That's the pesky "xpcs_an_inband" which ends up as phylink's > > "ovr_an_inband"... I'm sure these are random renames of stuff > > to make sure that people struggle to follow the code. > > > It is as mentioned above, the "xpcs_an_inband" will end up as > "ovr_an_inband" which will then > set pl->cfg_link_an_mode = MLO_AN_INBAND in the > phylink_parse_mode() in phylink.c
Let me make my comment more clear, because I don't think you understood it correctly.
Please rename "xpcs_an_inband" to "ovr_an_inband" or "phylink_ovr_an_inband" so it's obvious what it is and where it ends up.
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |