Messages in this thread | | | Date | Tue, 21 Mar 2023 09:01:08 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH next] tpm: Fix a possible dereference of ERR_PTR in tpm_init() |
| |
On Mon, Mar 20, 2023 at 11:14:15PM -0700, Harshit Mogalapalli wrote: > Smatch reports: > drivers/char/tpm/tpm-interface.c:470 tpm_init() error: > 'tpm_class' dereferencing possible ERR_PTR() > > If class_create() returns error pointer, we are dereferencing a possible > error pointer. Fix this by moving the dereference post error handling. > > Fixes: a010eb881243 ("tpm: fix up the tpm_class shutdown_pre pointer when created") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > This is based on static analysis, only compile tested.
Thanks for this, good catch, I've queued it up in my tree now as I have the offending change that caused this.
greg k-h
| |