Messages in this thread | | | Date | Wed, 22 Mar 2023 00:21:48 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH RESEND] EDAC/altera: Remove redundant error logging |
| |
On Thu, Mar 02, 2023 at 12:43:31AM +0530, Deepak R Varma wrote: > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its return > value in the caller is redundant and should be removed. The clean up > also makes if condition block braces unnecessary. Remove that as well. > > Issue identified using platform_get_irq.cocci coccinelle semantic patch. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > Note: > The change was compile tested only. > Resending the patch for a review and feedback. > > drivers/edac/altera_edac.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |