lkml.org 
[lkml]   [2023]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] staging: greybus: use inline function for macros
From
On 3/21/23 4:29 PM, Julia Lawall wrote:
> There do seem to be more than 100 definitions like:
>
> #define to_dove_clk(hw) container_of(hw, struct dove_clk, hw)
>
> where we have to hope that at all of the usage sites the argument is
> called hw. Probably anything else would cause a compiler error, but still
> it looks strange.
>
> julia

Yeah, that's poorly done and unfortunate. The argument to
the parameter should be named something different. I didn't
understand what you meant before but yes, this isn't good.
These should be fixed first.

-Alex

\
 
 \ /
  Last update: 2023-03-27 01:11    [W:0.076 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site