Messages in this thread | | | Subject | Re: [PATCH] ALSA: ymfpci: remove unused snd_ymfpci_readb function | From | Tom Rix <> | Date | Mon, 20 Mar 2023 05:33:28 -0700 |
| |
On 3/19/23 4:34 PM, Nathan Chancellor wrote: > On Sun, Mar 19, 2023 at 09:09:22AM +0100, Takashi Iwai wrote: >> On Sat, 18 Mar 2023 14:27:08 +0100, >> Tom Rix wrote: >>> clang with W=1 reports >>> sound/pci/ymfpci/ymfpci_main.c:34:18: error: >>> unused function 'snd_ymfpci_readb' [-Werror,-Wunused-function] >>> static inline u8 snd_ymfpci_readb(struct snd_ymfpci *chip, u32 offset) >>> ^ >>> This static function is not used, so remove it. >>> >>> Signed-off-by: Tom Rix <trix@redhat.com> >> I applied now, but still wondering why it warns at all even if it's a >> static inline function... > See commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > inline functions for W=1 build") for some more information. The key part > of the commit message is 'with W=1', this will not happen with a normal > clang build.
IMO from this general cleanup, being at W=1, is the correct location.
There many functions that could be removed and some that should not be.
Tom
> > Cheers, > Nathan > >>> --- >>> sound/pci/ymfpci/ymfpci_main.c | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c >>> index c80114c0ad7b..2858736ed20a 100644 >>> --- a/sound/pci/ymfpci/ymfpci_main.c >>> +++ b/sound/pci/ymfpci/ymfpci_main.c >>> @@ -31,11 +31,6 @@ >>> >>> static void snd_ymfpci_irq_wait(struct snd_ymfpci *chip); >>> >>> -static inline u8 snd_ymfpci_readb(struct snd_ymfpci *chip, u32 offset) >>> -{ >>> - return readb(chip->reg_area_virt + offset); >>> -} >>> - >>> static inline void snd_ymfpci_writeb(struct snd_ymfpci *chip, u32 offset, u8 val) >>> { >>> writeb(val, chip->reg_area_virt + offset); >>> -- >>> 2.27.0 >>>
| |