Messages in this thread | | | Date | Mon, 20 Mar 2023 11:16:19 +0530 | Subject | Re: [PATCH v9 3/4] clk: qcom: lpassaudiocc-sc7280: Add required gdsc power domain clks in lpass_cc_sc7280_desc strcuture | From | Mohammad Rafi Shaik <> |
| |
On 3/18/2023 12:13 AM, Stephen Boyd wrote: > Just remove strcuture from the subject. > > Quoting Mohammad Rafi Shaik (2023-03-17 07:16:21) >> Add the gdsc's in lpass_cc_sc7280_desc strcuture, > s/strcuture/struct/ > >> When qcom,adsp-pil-mode is enabled, gdsc's required to solve > Just 'GDSCs', because gdsc isn't owning anything. > >> dependencies in lpass_audiocc probe. > I think you're saying that we need to register the GDSCs when > qcom,adsp-pil-mode is set in the qcom,sc7280-lpassaoncc node. Otherwise, > we don't get any GDSCs provided by that node when we should always be > providing them.
Yes, need to register GDSCs when qcom,adsp-pil-mode is set in the qcom,sc7280-lpassaoncc node.
The lpass_audiocc requires GDSCs to probe become success.
>> Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC7280") > If the above is right, then this fixes tag is wrong. It should really be > > Fixes: 0cbcfbe50cbf ("clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon") > > right? Okay, will change fixes tag.
| |