lkml.org 
[lkml]   [2023]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] staging: greybus: use inline function for macros
    Date
    Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a
    static inline function.

    it is not great to have macro that use `container_of` macro,
    because from looking at the definition one cannot tell what type
    it applies to.

    One can get the same benefit from an efficiency point of view
    by making an inline function.

    Suggested-by: Julia Lawall <julia.lawall@inria.fr>
    Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
    ---
    drivers/staging/greybus/gbphy.h | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
    index d4a225b76338..03a977056637 100644
    --- a/drivers/staging/greybus/gbphy.h
    +++ b/drivers/staging/greybus/gbphy.h
    @@ -15,7 +15,10 @@ struct gbphy_device {
    struct list_head list;
    struct device dev;
    };
    -#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
    +static inline struct gbphy_device *to_gbphy_dev(const struct device *d)
    +{
    + return container_of(d, struct gbphy_device, dev);
    +}

    static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
    {
    @@ -43,7 +46,10 @@ struct gbphy_driver {

    struct device_driver driver;
    };
    -#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
    +static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d)
    +{
    + return container_of(d, struct gbphy_driver, driver);
    +}

    int gb_gbphy_register_driver(struct gbphy_driver *driver,
    struct module *owner, const char *mod_name);
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-03-27 01:10    [W:3.048 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site