Messages in this thread | | | Date | Thu, 2 Mar 2023 18:14:59 +0000 | From | Al Viro <> | Subject | Re: [PATCH] locks: avoid usage of list iterator after loop in generic_delete_lease() |
| |
On Wed, Mar 01, 2023 at 06:20:18PM +0100, Jakob Koschel wrote: > 'victim' and 'fl' are ensured to be equal at this point. For consistency > both should use the same variable. > > Additionally, Linus proposed to avoid any use of the list iterator > variable after the loop, in the attempt to move the list iterator > variable declaration into the marcro to avoid any potential misuse after > the loop [1]. > > Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1] > Signed-off-by: Jakob Koschel <jkl820.git@gmail.com>
Looks sane. Jeff, which tree do you want that to go through?
| |