lkml.org 
[lkml]   [2023]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] cxl/hdm: Fix hdm decoder init by adding COMMIT field check
From


On 3/2/23 9:28 AM, Davidlohr Bueso wrote:
> On Thu, 02 Mar 2023, Dave Jiang wrote:
>
>> It does sound like a bug with QEMU emulation currently.
>
> Agreed, but still, crashing the kernel is always a no no - like with
> the passthrough decoder situation we had.

I wonder if we are missing a check in cxl_decoder_commit() to exit if
COMMITTED bit is set in register. The current code just blindly start
programming the registers.

>
> Thanks,
> Davidlohr

\
 
 \ /
  Last update: 2023-03-27 00:42    [W:0.148 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site