lkml.org 
[lkml]   [2023]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/18] media: venus: hfi_venus: Set venus_sys_idle_indicator to false on V6
From

On 2/28/2023 10:23 PM, Bryan O'Donoghue wrote:
> On 28/02/2023 15:41, Konrad Dybcio wrote:
>>> Can you test it and make sure ?
>> As I mentioned in the cover letter, 8250 still seems to work with this
>> patchset. I have no idea how one would go about validating the
>> functionality enabled through this call.
>
> We offlined about this.
>
> I think it is correct to say you don't have access to a display to
> test this on sm8250.
>
> I do so, I will try this out for you, though I'll wait for your V2 for
> this series.
>
> ---
> bod

Hi Konrad,

I understand from your commit text, setting this indicator for AR50L is
causing issue with suspend.

Ideally it shouldn't cause any such issue. I checked with FW team and
got to know that this property is not supported on AR50LT so if you set
it there should be some property not supported error.

In my opinion it would be good to replace these versions checks with VPU
version check you have introduced in your other patch and keep this
setting for current targets and not set wherever not needed eg AR50LT.

Thanks,

Dikshita

\
 
 \ /
  Last update: 2023-03-27 00:41    [W:0.772 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site