lkml.org 
[lkml]   [2023]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 08/10] perf parse-events: Pass ownership of the group name
Em Wed, Mar 01, 2023 at 08:12:09PM -0800, Ian Rogers escreveu:
> Pass ownership of the group name rather than copying and freeing the
> original. This saves a memory allocation and copy.

Looks ok.

- Arnaldo

> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/parse-events.c | 3 ++-
> tools/perf/util/parse-events.y | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 0336ff27c15f..1be454697d57 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1761,6 +1761,7 @@ parse_events__set_leader_for_uncore_aliase(char *name, struct list_head *list,
>
> handled:
> ret = 1;
> + free(name);
> out:
> free(leaders);
> return ret;
> @@ -1786,7 +1787,7 @@ void parse_events__set_leader(char *name, struct list_head *list,
>
> leader = arch_evlist__leader(list);
> __perf_evlist__set_leader(list, &leader->core);
> - leader->group_name = name ? strdup(name) : NULL;
> + leader->group_name = name;
> list_move(&leader->core.node, list);
> }
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index be8c51770051..541b8dde2063 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -202,8 +202,8 @@ PE_NAME '{' events '}'
> struct list_head *list = $3;
>
> inc_group_count(list, _parse_state);
> + /* Takes ownership of $1. */
> parse_events__set_leader($1, list, _parse_state);
> - free($1);
> $$ = list;
> }
> |
> --
> 2.39.2.722.g9855ee24e9-goog
>

--

- Arnaldo

\
 
 \ /
  Last update: 2023-03-27 00:42    [W:0.108 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site