Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH 1/2] dt-bindings: iio: ad74413r: allow setting sink current for digital input | Date | Thu, 02 Mar 2023 08:24:58 -0600 |
| |
On Thu, 02 Mar 2023 14:49:20 +0100, Rasmus Villemoes wrote: > Depending on the actual hardware wired up to a digital input channel, > it may be necessary to configure the ad74413r to sink a small > current. For example, in the case of a simple mechanical switch, the > charge on the external 68 nF capacitor (cf. the data sheet's Figure > 34) will keep the channel as reading high even after the switch is > turned off again. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > .../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml: patternProperties:^channel@[0-3]$:properties:drive-strength-microamp: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230302134922.1120217-2-linux@rasmusvillemoes.dk
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
| |