Messages in this thread | | | Date | Thu, 2 Mar 2023 13:10:30 +0000 | Subject | Re: [PATCH] ASoC: qcom: q6prm: fix incorrect clk_root passed to ADSP | From | Srinivas Kandagatla <> |
| |
On 02/03/2023 12:29, Krzysztof Kozlowski wrote: > The second to last argument is clk_root (root of the clock), however the > code called q6prm_request_lpass_clock() with clk_attr instead > (copy-paste error). This effectively was passing value of 1 as root > clock which worked on some of the SoCs (e.g. SM8450) but fails on > others, depending on the ADSP. For example on SM8550 this "1" as root > clock is not accepted and results in errors coming from ADSP. > > Fixes: 2f20640491ed ("ASoC: qdsp6: qdsp6: q6prm: handle clk disable correctly") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Nice Find, Tested on sc8280xp
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini > --- > sound/soc/qcom/qdsp6/q6prm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/qcom/qdsp6/q6prm.c b/sound/soc/qcom/qdsp6/q6prm.c > index 8aa1a213bfb7..c1dc5bae715a 100644 > --- a/sound/soc/qcom/qdsp6/q6prm.c > +++ b/sound/soc/qcom/qdsp6/q6prm.c > @@ -183,9 +183,9 @@ int q6prm_set_lpass_clock(struct device *dev, int clk_id, int clk_attr, int clk_ > unsigned int freq) > { > if (freq) > - return q6prm_request_lpass_clock(dev, clk_id, clk_attr, clk_attr, freq); > + return q6prm_request_lpass_clock(dev, clk_id, clk_attr, clk_root, freq); > > - return q6prm_release_lpass_clock(dev, clk_id, clk_attr, clk_attr, freq); > + return q6prm_release_lpass_clock(dev, clk_id, clk_attr, clk_root, freq); > } > EXPORT_SYMBOL_GPL(q6prm_set_lpass_clock); >
| |