Messages in this thread | | | From | Ryan Chen <> | Subject | RE: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 | Date | Sun, 19 Mar 2023 02:05:46 +0000 |
| |
Hello,
> -----Original Message----- > From: Andi Shyti <andi.shyti@kernel.org> > Sent: Saturday, March 18, 2023 5:10 PM > To: Ryan Chen <ryan_chen@aspeedtech.com> > Cc: Andrew Jeffery <andrew@aj.id.au>; Brendan Higgins > <brendan.higgins@linux.dev>; Benjamin Herrenschmidt > <benh@kernel.crashing.org>; Joel Stanley <joel@jms.id.au>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Philipp Zabel > <p.zabel@pengutronix.de>; linux-i2c@vger.kernel.org; > openbmc@lists.ozlabs.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for > AST2600-i2cv2 > > Hi Ryan, > > On Sun, Feb 26, 2023 at 11:13:20AM +0800, Ryan Chen wrote: > > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout > > aspeed,xfer-mode description for ast2600-i2cv2. > > > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 > +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > index f597f73ccd87..75de3ce41cf5 100644 > > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > @@ -49,6 +49,25 @@ properties: > > description: > > states that there is another master active on this bus > > > > + aspeed,timeout: > > + type: boolean > > + description: I2C bus timeout enable for master/slave mode > > Finally you can proceed with this. Please remove "aspeed,timeout" > and use "i2c-scl-has-clk-low-timeout" instead.
Thanks a lot, I will start progress this.
Best Regards Ryan
| |