Messages in this thread | | | Date | Thu, 16 Mar 2023 17:20:36 +0100 | Subject | Re: [PATCH net-next] net: macb: Reset TX when TX halt times out | From | Nicolas Ferre <> |
| |
On 16/03/2023 at 11:54, Michal Swiatkowski wrote: > On Thu, Mar 16, 2023 at 02:05:54PM +0530, Harini Katakam wrote: >> From: Harini Katakam <harini.katakam@xilinx.com> >> >> Reset TX when halt times out i.e. disable TX, clean up TX BDs, >> interrupts (already done) and enable TX. >> This addresses the issue observed when iperf is run at 10Mps Half >> duplex where, after multiple collisions and retries, TX halts. >> >> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> >> --- >> drivers/net/ethernet/cadence/macb_main.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >> index 96fd2aa9ee90..473c2d0174ad 100644 >> --- a/drivers/net/ethernet/cadence/macb_main.c >> +++ b/drivers/net/ethernet/cadence/macb_main.c >> @@ -1021,6 +1021,7 @@ static void macb_tx_error_task(struct work_struct *work) >> struct sk_buff *skb; >> unsigned int tail; >> unsigned long flags; >> + bool halt_timeout = false; > RCT
Yes, might not pass the netdev checks.
> Otherwise looks fine > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Likewise, this fixed: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Best regards, Nicolas
> > [...] > >> -- >> 2.17.1 >>
-- Nicolas Ferre
| |