lkml.org 
[lkml]   [2023]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] Staging: octeon: Fix line ending with '('
From
Hi--

On 3/16/23 08:52, Sumitra Sharma wrote:
> Adhere to coding-style.
>
> Checkpatch has reported code style warning:
> CHECK: Lines should not end with a '('.
>

Not to complain about the patch, but where is this documented
in coding-style? I searched for it and cannot find it.


Thanks.

> Enhance the design of a function header:
> Align the function parameters immediately after '(' in a single line.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
>
> v2: Change patch subject and description.
>
> drivers/staging/octeon/octeon-stubs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 7a02e59e283f..3e7b92cd2e35 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
> int32_t value)
> { }
>
> -static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> - int interface,
> - int port)
> +static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
> {
> union cvmx_gmxx_rxx_rx_inbnd r;
>

--
~Randy

\
 
 \ /
  Last update: 2023-03-27 01:04    [W:0.051 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site