Messages in this thread | | | From | "Zhuo, Qiuxu" <> | Subject | RE: [PATCH 1/1] rcu/rcuscale: Stop kfree_scale_thread thread(s) after unloading rcuscale | Date | Thu, 16 Mar 2023 13:17:10 +0000 |
| |
> From: Paul E. McKenney <paulmck@kernel.org> > [...] > > > > > > How about to pull the rcu_scale_cleanup() function after > kfree_scale_cleanup(). > > > This groups kfree_* functions and groups rcu_scale_* functions. > > > Then the code would look cleaner. > > > So, do you think the changes below are better? > > > > IMHO, I don't think doing such a code move is better. Just add a new > > header file and declare the function there. But see what Paul says > > first. > > This situation is likely to be an early hint that the kvfree_rcu() testing should > be split out from kernel/rcu/rcuscale.c.
Another is that it's a bit expensive to create a new header file just for eliminating a function declaration. ;-)
So, if no objections, I'd like to send out the v2 patch with the updates below:
- Move rcu_scale_cleanup() after kfree_scale_cleanup() to eliminate the declaration of kfree_scale_cleanup(). Though this makes the patch bigger, get the file rcuscale.c much cleaner.
- Remove the unnecessary step "modprobe torture" from the commit message.
- Add the description for why move rcu_scale_cleanup() after kfree_scale_cleanup() to the commit message.
Thanks! -Qiuxu
> [...]
| |