Messages in this thread | | | Date | Thu, 16 Mar 2023 07:36:05 +0100 | Subject | Re: [PATCH V2 2/3] arm64: dts: ti: Use local header for pinctrl register values | From | Krzysztof Kozlowski <> |
| |
On 15/03/2023 16:52, Nishanth Menon wrote: > The DTS uses hardware register values directly in pin controller pin > configuration and not an abstraction of any form. > > These definitions were previously put in the bindings header to avoid > code duplication and to provide some context meaning (name), but they > do not fit the purpose of bindings. > > Store the constants in a header next to DTS and use them instead of > bindings. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Suggested-by: Linus Walleij <linus.walleij@linaro.org> > Link: https://lore.kernel.org/all/c4d53e9c-dac0-8ccc-dc86-faada324beba@linaro.org/ > Signed-off-by: Nishanth Menon <nm@ti.com> > ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |