Messages in this thread | | | Date | Thu, 16 Mar 2023 13:49:19 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 2/7] drivers: misc: Add support for the Lantiq PEF2256 framer |
| |
On Thu, Mar 16, 2023 at 01:27:36PM +0100, Herve Codina wrote: > +EXPORT_SYMBOL(pef2256_get_byphandle);
You have a mixture of EXPORT_SYMBOL() and EXPORT_SYMBOL_GPL() in the same file here. As this one:
> + > +void pef2256_put(struct pef2256 *pef2256) > +{ > + put_device(pef2256->dev); > +} > +EXPORT_SYMBOL(pef2256_put);
Is just a wrapper around a EXPORT_SYMBOL_GPL() function, please revisit and perhaps make them all EXPORT_SYMBOL_GPL() calls?
thanks,
greg k-h
| |