Messages in this thread | | | Date | Thu, 16 Mar 2023 12:59:10 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 2/3] serial: uart_poll_init() should power on the UART |
| |
On Mon, Mar 13, 2023 at 01:53:02PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Mar 7, 2023 at 7:32 AM Douglas Anderson <dianders@chromium.org> wrote: > > > > On Qualcomm devices which use the "geni" serial driver, kdb/kgdb won't > > be very happy if you use it but the resources of the port haven't been > > powered on. Today kdb/kgdb rely on someone else powering the port > > on. This could be the normal kernel console or an agetty running. > > Let's fix this to explicitly power things on when setting up a polling > > driver. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > drivers/tty/serial/serial_core.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Just in case it's not obvious, even though we ended up going with > Johan's series [1] instead of patch #1 of my series, patch #2 and #3 > of my series are still relevant. I can repost the series without patch > #1 if it's helpful. > > [1] https://lore.kernel.org/r/20230307164405.14218-1-johan+linaro@kernel.org
Ye,s it's not obvious at all. Please resubmit.
thanks,
greg k-h
| |