Messages in this thread | | | Date | Thu, 16 Mar 2023 12:36:40 +0200 | From | Sakari Ailus <> | Subject | Re: [PATCHv3 1/2 RESEND] doc/media api: Try to make enum usage clearer |
| |
Hi Dorota,
On Wed, Mar 15, 2023 at 02:09:14PM +0100, Dorota Czaplejewicz wrote: > Hi, > > On Wed, 15 Mar 2023 12:14:28 +0200 > Sakari Ailus <sakari.ailus@iki.fi> wrote: > > > Hi Dorota, > > > > On Sun, Feb 19, 2023 at 12:00:34PM +0100, Dorota Czaplejewicz wrote: > > > This clarifies which side of the calls is responsible for doing what to which parts of the struct. > > > This also explicitly states that repeating values are disallowed. > > > It also expands the terse description of the access algorithm into more prose-like, active voice description, which trades conciseness for ease of comprehension. > > > > The commit message lines should be wrapped at 74 characters. Please do use > > checkpatch.pl in the future. There is also no apparent reason to add a > > newline after a period. > > > > The same applies to the other patch as well. > > > > I've addressed the issues this time. > > Thanks for taking a look. What is the next step?
Just remember to use checkpatch.pl, on media tree in particular it's:
$ checkpatch.pl --strict --max-line-length=80
-- Sakari Ailus
| |