Messages in this thread | | | Date | Thu, 16 Mar 2023 09:33:59 +0000 | From | y86-dev <> | Subject | Re: [PATCH v1 1/3] rust: macros: add `quote!` macro |
| |
On Monday, March 13th, 2023 at 16:30, Boqun Feng <boqun.feng@gmail.com> wrote: > On Mon, Mar 13, 2023 at 01:23:18AM +0000, y86-dev wrote: > > > From: Gary Guo gary@garyguo.net > > > > Add the `quote!` macro for creating `TokenStream`s directly via the > > given Rust tokens. It also supports repetitions using iterators. > > > > It will be used by the pin-init API proc-macros to generate code. > > > > Signed-off-by: Gary Guo gary@garyguo.net > > Signed-off-by: Benno Lossin y86-dev@protonmail.com > > > Not sure whether I missed any sutble details, but the macros look > straight-forward. One thing could be improved is having a doc describing > what `quote!` does, a link to the quote crate will do the trick. > > Anyway, the code looks good to me. > > Acked-by: Boqun Feng boqun.feng@gmail.com > > > Regards, > Boqun
Sure, will put it in v2!
Regards, Benno
| |