lkml.org 
[lkml]   [2023]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
    From


    Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
    From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    to: Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
    data: 2023/3/16

    > On 16/03/2023 09:02, Guo Samin wrote:
    >>
    >>
    >> -------- 原始信息 --------
    >> 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
    >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    >> 收件人: Samin Guo <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
    >> 日期: 2023/3/16
    >>
    >>> On 16/03/2023 05:37, Samin Guo wrote:
    >>>> From: Yanhong Wang <yanhong.wang@starfivetech.com>
    >>>>
    >>>> Add documentation to describe StarFive dwmac driver(GMAC).
    >>>>
    >>> Thank you for your patch. There is something to discuss/improve.
    >>>
    >>>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
    >>>> Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
    >>>> Tested-by: Tommaso Merciai <tomm.merciai@gmail.com>
    >>>> ---
    >>>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
    >>>> .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++
    >>>> MAINTAINERS | 6 +
    >>>> 3 files changed, 137 insertions(+)
    >>>> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
    >>>>
    >>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    >>>> index e4519cf722ab..245f7d713261 100644
    >>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    >>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    >>>> @@ -91,6 +91,7 @@ properties:
    >>>> - snps,dwmac-5.20
    >>>> - snps,dwxgmac
    >>>> - snps,dwxgmac-2.10
    >>>> + - starfive,jh7110-dwmac
    >>>>
    >>>> reg:
    >>>> minItems: 1
    >>>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
    >>>> new file mode 100644
    >>>> index 000000000000..b59e6bd8201f
    >>>> --- /dev/null
    >>>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
    >>>> @@ -0,0 +1,130 @@
    >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    >>>> +# Copyright (C) 2022 StarFive Technology Co., Ltd.
    >>>> +%YAML 1.2
    >>>> +---
    >>>> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml#
    >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
    >>>> +
    >>>> +title: StarFive JH7110 DWMAC glue layer
    >>>> +
    >>>> +maintainers:
    >>>> + - Emil Renner Berthing <kernel@esmil.dk>
    >>>> + - Samin Guo <samin.guo@starfivetech.com>
    >>>> +
    >>>> +select:
    >>>> + properties:
    >>>> + compatible:
    >>>> + contains:
    >>>> + enum:
    >>>> + - starfive,jh7110-dwmac
    >>>> + required:
    >>>> + - compatible
    >>>> +
    >>>> +properties:
    >>>> + compatible:
    >>>> + items:
    >>>> + - enum:
    >>>> + - starfive,jh7110-dwmac
    >>>> + - const: snps,dwmac-5.20
    >>>> +
    >>>
    >>> reg:
    >>> maxItems: 1
    >>
    >>>
    >>>> + clocks:
    >>>> + items:
    >>>> + - description: GMAC main clock
    >>>> + - description: GMAC AHB clock
    >>>> + - description: PTP clock
    >>>> + - description: TX clock
    >>>> + - description: GTX clock
    >>>> +
    >>>> + clock-names:
    >>>> + items:
    >>>> + - const: stmmaceth
    >>>> + - const: pclk
    >>>> + - const: ptp_ref
    >>>> + - const: tx
    >>>> + - const: gtx
    >>>> +
    >>>
    >>> interrupts: ???
    >>>
    >>
    >> Hi Krzysztof,
    >>
    >> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes,
    >> and the JH7110 SoC is also applicable.
    >> Maybe just add reg/interrupt/interrupt-names to the required ?
    >
    > You need to constrain them.


    I see. I will add reg constraints in the next version, thanks.

    I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml,
    do these also need to be constrained?


    Best regards,
    Samin
    >
    >>
    >>
    >> required:
    >> - compatible
    >> + - reg
    >> - clocks
    >> - clock-names
    >> + - interrupts
    >> + - interrupt-names
    >> - resets
    >> - reset-names
    > Best regards,
    > Krzysztof
    >


    \
     
     \ /
      Last update: 2023-03-27 01:03    [W:3.061 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site