Messages in this thread | | | Date | Thu, 16 Mar 2023 09:03:01 +0100 | Subject | Re: [PATCH v2] ASoC: dt-bindings: adi,adau17x1: Convert to DT schema | From | Krzysztof Kozlowski <> |
| |
On 16/03/2023 00:10, Vijaya Anand wrote: > Convert the binding document for adi,adau17x1 from txt to yaml > so one could validate dt-entries correctly and any future additions > can go into yaml format. Add address and size cells to example to > prevent errors regarding reg format. > > Signed-off-by: Vijaya Anand <sunrockers8@gmail.com> > Cc: Daniel Baluta <daniel.baluta@nxp.com> > --- > Changes since v1: > - added 'Codec' in title to clarify type of devices > - put compatible devices in lexographic order > - changed description of clocks > - changed 'unevaluatedProperties' to 'additionalProperties' > - changed node names to be generic
You sent a v2, so this should be v3. Keep it consistent, otherwise it confuses reviewers...
> > --- > .../bindings/sound/adi,adau17x1.txt | 32 ------------ > .../bindings/sound/adi,adau17x1.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 32 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/adi,adau17x1.txt > create mode 100644 Documentation/devicetree/bindings/sound/adi,adau17x1.yaml
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |