Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 17 Mar 2023 11:45:21 +0800 | From | Chester Lin <> | Subject | Re: [PATCH 0/3] pinctrl: s32: driver improvements and generic struct use |
| |
Hi Andy,
On Tue, Mar 14, 2023 at 07:21:55PM +0200, Andy Shevchenko wrote: > On Tue, Mar 14, 2023 at 3:46 PM Chester Lin <clin@suse.com> wrote: > > > > Hello, > > > > This patch series contains some improvements for s32 pinctrl drivers suggested > > by upstream[1], such as > > > > - Fix error shadowings and improve return value handlings. > > - Fix print format. > > - Remove unnecessary blanks. > > - Use proper macros and helpers to simplify codes. > > - Refactor config param parsing and remove config arguments that are never used. > > - Use generic struct pingroup and struct pinfunction to describe pin data. > > Overall it looks not bad, thank you for doing this. > Individual patches have been reviewed and commented accordingly.
Thank you for reviewing this patch. I will fix the rest in v2 soon.
Regards, Chester
> > -- > With Best Regards, > Andy Shevchenko
| ![\](/images/icornerr.gif) |