lkml.org 
[lkml]   [2023]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] dt-bindings: display: add panel-timing property to sitronix,st7789v
    On Tue, Mar 14, 2023 at 12:56:44PM +0100, Gerald Loacker wrote:
    > The sitronix-st7789v driver now considers the panel-timing property.

    I read the patch for that and still don't know 'why'. Commit messages
    should answer why.

    > Add the property to the documentation.

    We generally don't put timings in DT for panels. Why is this one
    special?

    >
    > Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
    > ---
    > .../display/panel/sitronix,st7789v.yaml | 17 +++++++++++++++++
    > 1 file changed, 17 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
    > index ed942cd3620f..8810f123dedf 100644
    > --- a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
    > +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
    > @@ -21,6 +21,7 @@ properties:
    > reset-gpios: true
    > power-supply: true
    > backlight: true
    > + panel-timing: true
    > port: true
    > rotation: true
    >
    > @@ -54,6 +55,22 @@ examples:
    > spi-cpol;
    > spi-cpha;
    >
    > + panel-timing {
    > + clock-frequency = <7000000>;
    > + hactive = <240>;
    > + vactive = <320>;
    > + hfront-porch = <38>;
    > + hback-porch = <10>;
    > + hsync-len = <10>;
    > + vfront-porch = <8>;
    > + vback-porch = <4>;
    > + vsync-len = <4>;
    > + hsync-active = <1>;
    > + vsync-active = <1>;
    > + de-active = <1>;
    > + pixelclk-active = <1>;
    > + };
    > +
    > port {
    > panel_input: endpoint {
    > remote-endpoint = <&tcon0_out_panel>;
    > --
    > 2.37.2
    >

    \
     
     \ /
      Last update: 2023-03-27 01:04    [W:8.703 / U:1.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site