Messages in this thread | | | Date | Thu, 16 Mar 2023 13:01:47 -0700 | Subject | Re: [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface is not up | From | Florian Fainelli <> |
| |
On 3/15/23 00:41, Wolfram Sang wrote: > RAVB doesn't need mdiobus suspend/resume, that's why it sets > 'mac_managed_pm'. However, setting it needs to be moved from init to > probe, so mdiobus PM functions will really never be called (e.g. when > the interface is not up yet during suspend/resume). > > Fixes: 4924c0cdce75 ("net: ravb: Fix PHY state warning splat during system resume") > Suggested-by: Heiner Kallweit <hkallweit1@gmail.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
This is a pattern that a lot of drivers have, for better or for worse, it would be neat if we couldcome up with a common helper that could work mostly with OF configurations, what do you think? -- Florian
| |