Messages in this thread | | | Date | Thu, 16 Mar 2023 08:13:24 +0100 | Subject | Re: [PATCH net-next 01/11] dt-bindings: net: snps,dwmac: Update interrupt-names | From | Krzysztof Kozlowski <> |
| |
On 13/03/2023 17:56, Andrew Halaney wrote: > From: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > As commit fc191af1bb0d ("net: stmmac: platform: Fix misleading > interrupt error msg") noted, not every stmmac based platform > makes use of the 'eth_wake_irq' or 'eth_lpi' interrupts. > > So, update the 'interrupt-names' inside 'snps,dwmac' YAML > bindings to reflect the same. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- > > I picked this up from: > https://lore.kernel.org/netdev/20220929060405.2445745-2-bhupesh.sharma@linaro.org/ > No changes other than collecting the Acked-by. > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 16b7d2904696..52ce14a4bea7 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -105,8 +105,8 @@ properties: > minItems: 1 > items: > - const: macirq > - - const: eth_wake_irq > - - const: eth_lpi > + - enum: [eth_wake_irq, eth_lpi] > + - enum: [eth_wake_irq, eth_lpi]
I acked it before but this is not correct. This should be: + - enum: [eth_wake_irq, eth_lpi] + - enum: eth_lpi
Best regards, Krzysztof
| |