Messages in this thread | | | Date | Thu, 16 Mar 2023 18:37:25 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH v3] Staging: octeon: Fix line ending with '(' |
| |
On Thu, 16 Mar 2023, Sumitra Sharma wrote:
> Since, the coding-style limit the code within 80 columns per line. This > causes splitting the function header into two lines and results the > first line ending with a '('. This causes the checkpatch error.
This should all be in the past tense: limited, caused, resulted, etc.
julia
> > Place the function parameters immediately after '(' in a single > line to align the function header. > > Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com> > --- > v2: Change patch subject and description > > v3: Change patch description, noted by Deepak R Varma <drv@mailo.com> > > > drivers/staging/octeon/octeon-stubs.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h > index 7a02e59e283f..3e7b92cd2e35 100644 > --- a/drivers/staging/octeon/octeon-stubs.h > +++ b/drivers/staging/octeon/octeon-stubs.h > @@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr, > int32_t value) > { } > > -static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed( > - int interface, > - int port) > +static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port) > { > union cvmx_gmxx_rxx_rx_inbnd r; > > -- > 2.25.1 > > >
| |