Messages in this thread | | | Date | Wed, 15 Mar 2023 08:06:51 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 3/4] blk-integrity: register sysfs attributes on struct device |
| |
> +static const struct attribute_group integrity_group = {
Double whitespace before the =
> + .name = "integrity", .attrs = integrity_attrs, > };
We generally put each field member on separate lines for readability.
> int blk_integrity_add(struct gendisk *disk) > { > + return device_add_groups(disk_to_dev(disk), integrity_groups); > } > > void blk_integrity_del(struct gendisk *disk) > { > + device_remove_groups(disk_to_dev(disk), integrity_groups);
Can't we just add integrity_group to disk_attr_groups and remove these calls entirely?
| |