Messages in this thread | | | Date | Wed, 15 Mar 2023 15:16:42 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH net-next v6 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() |
| |
On Wed, Mar 15, 2023 at 06:57:37AM +0100, Michal Swiatkowski wrote: > On Tue, Mar 14, 2023 at 08:18:24PM +0200, Andy Shevchenko wrote: > > LED core provides a helper to parse default state from firmware node. > > Use it instead of custom implementation.
...
> You have to fix implict declaration of the led_init_default_state_get().
Seems like users have to choose between 'select NEW_LEDS' and 'depends on NEW_LEDS' in the Kconfig.
> I wonder if the code duplication here can be avoided:
Whether or not this is out of the scope of this patch. Feel free to submit one :-)
...
> Only suggestion, patch looks good.
Thank you!
-- With Best Regards, Andy Shevchenko
| |