lkml.org 
[lkml]   [2023]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/7] soc: qcom: icc-bwmon: Handle global registers correctly
From
On 15/03/2023 11:13, Konrad Dybcio wrote:
>>> }
>>>
>>> static int bwmon_probe(struct platform_device *pdev)
>>> @@ -645,6 +816,21 @@ static const struct icc_bwmon_data msm8998_bwmon_data = {
>>> .quirks = BWMON_HAS_GLOBAL_IRQ,
>>> .regmap_fields = msm8998_bwmon_reg_fields,
>>> .regmap_cfg = &msm8998_bwmon_regmap_cfg,
>>> + .global_regmap_fields = msm8998_bwmon_global_reg_fields,
>>> + .global_regmap_cfg = &msm8998_bwmon_global_regmap_cfg,
>>> +};
>>> +
>>> +static const struct icc_bwmon_data sdm845_ddr_bwmon_data = {
>>
>> The name "ddr" is here (and other places) confusing. This is not the DDR
>> bwmon.
> I suppose cpu_bwmon could make more sense?

Yes, we keep calling it CPU.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-27 01:01    [W:0.836 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site