lkml.org 
[lkml]   [2023]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 13/17] PM: EM: Refactor struct em_perf_domain and add default_table
    Hi Lukasz,

    I love your patch! Perhaps something to improve:

    [auto build test WARNING on rafael-pm/linux-next]
    [also build test WARNING on rafael-pm/thermal linus/master pavel-leds/for-next v6.3-rc2 next-20230315]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Lukasz-Luba/PM-EM-Refactor-em_cpufreq_update_efficiencies-arguments/20230314-184448
    base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
    patch link: https://lore.kernel.org/r/20230314103357.26010-14-lukasz.luba%40arm.com
    patch subject: [PATCH 13/17] PM: EM: Refactor struct em_perf_domain and add default_table
    config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20230315/202303151927.WD6O0PWN-lkp@intel.com/config)
    compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/ce3aad5db08006a2a6b6d52f9c26b11448cd8bb4
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Lukasz-Luba/PM-EM-Refactor-em_cpufreq_update_efficiencies-arguments/20230314-184448
    git checkout ce3aad5db08006a2a6b6d52f9c26b11448cd8bb4
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/thermal/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>
    | Link: https://lore.kernel.org/oe-kbuild-all/202303151927.WD6O0PWN-lkp@intel.com/

    All warnings (new ones prefixed by >>):

    >> drivers/thermal/cpufreq_cooling.c:381:24: warning: unused variable 'table' [-Wunused-variable]
    struct em_perf_state *table;
    ^
    1 warning generated.


    vim +/table +381 drivers/thermal/cpufreq_cooling.c

    376
    377 static unsigned int get_state_freq(struct cpufreq_cooling_device *cpufreq_cdev,
    378 unsigned long state)
    379 {
    380 struct cpufreq_policy *policy;
    > 381 struct em_perf_state *table;
    382 unsigned long idx;
    383

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-27 01:01    [W:4.402 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site