Messages in this thread | | | Date | Wed, 15 Mar 2023 15:43:31 +0800 | Subject | Re: [PATCH v6] scsi: ufs: core: Add trace event for MCQ | From | Ziqi Chen <> |
| |
Hi Bart,
Sure, will fix it.
Best Regards, Ziqi
On 3/15/2023 2:13 AM, Bart Van Assche wrote: > On 3/14/23 04:15, Ziqi Chen wrote: >> TP_printk( >> - "%s: %s: tag: %u, DB: 0x%x, size: %d, IS: %u, LBA: %llu, >> opcode: 0x%x (%s), group_id: 0x%x", >> - show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name), >> - __entry->tag, __entry->doorbell, __entry->transfer_len, >> - __entry->intr, __entry->lba, (u32)__entry->opcode, >> - str_opcode(__entry->opcode), (u32)__entry->group_id >> + "%s: %s: tag: %u, DB: 0x%x, size: %d, IS: %u, LBA: %llu, >> opcode: 0x%x (%s), group_id: 0x%x, hwq_id: %d", >> + show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name), >> + __entry->tag, __entry->doorbell, __entry->transfer_len, >> __entry->intr, >> + __entry->lba, (u32)__entry->opcode, >> str_opcode(__entry->opcode), >> + (u32)__entry->group_id, __entry->hwq_id > > The alignment of the TP_printk() arguments looks odd. Please make sure > that arguments 2 and later start in the same column as the opening > double quote (") instead of one column to the right of that double quote. > > Thanks, > > Bart. >
| |