lkml.org 
[lkml]   [2023]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6] scsi: ufs: core: Add trace event for MCQ
From
Hi Bart,

Sure, will fix it.


Best Regards,
Ziqi

On 3/15/2023 2:13 AM, Bart Van Assche wrote:
> On 3/14/23 04:15, Ziqi Chen wrote:
>>       TP_printk(
>> -        "%s: %s: tag: %u, DB: 0x%x, size: %d, IS: %u, LBA: %llu,
>> opcode: 0x%x (%s), group_id: 0x%x",
>> -        show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name),
>> -        __entry->tag, __entry->doorbell, __entry->transfer_len,
>> -        __entry->intr, __entry->lba, (u32)__entry->opcode,
>> -        str_opcode(__entry->opcode), (u32)__entry->group_id
>> +        "%s: %s: tag: %u, DB: 0x%x, size: %d, IS: %u, LBA: %llu,
>> opcode: 0x%x (%s), group_id: 0x%x, hwq_id: %d",
>> +         show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name),
>> +         __entry->tag, __entry->doorbell, __entry->transfer_len,
>> __entry->intr,
>> +         __entry->lba, (u32)__entry->opcode,
>> str_opcode(__entry->opcode),
>> +         (u32)__entry->group_id, __entry->hwq_id
>
> The alignment of the TP_printk() arguments looks odd. Please make sure
> that arguments 2 and later start in the same column as the opening
> double quote (") instead of one column to the right of that double quote.
>
> Thanks,
>
> Bart.
>

\
 
 \ /
  Last update: 2023-03-27 01:00    [W:1.576 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site