Messages in this thread | | | Date | Wed, 15 Mar 2023 08:04:16 +0100 | Subject | Re: [PATCH v2] Fix buffer overrun in HID-SENSOR name string | From | Krzysztof Kozlowski <> |
| |
On 13/03/2023 23:06, Todd Brandt wrote: > On some platforms there are some platform devices created with > invalid names. For example: "HID-SENSOR-INT-020b?.39.auto" instead > of "HID-SENSOR-INT-020b.39.auto" > > This string include some invalid characters, hence it will fail to > properly load the driver which will handle this custom sensor. Also > it is a problem for some user space tools, which parse the device > names from ftrace and dmesg. > > This is because the string, real_usage, is not NULL terminated and > printed with %s to form device name. > > To address this, we initialize the real_usage string with 0s. > > Philipp Jungkamp created this fix, I'm simply submitting it. I've > verified it fixes bugzilla issue 217169 > > Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com> > Signed-off-by: Todd Brandt <todd.e.brandt@intel.com>
SoB denotes that you reported this and tested. Otherwise shall we start adding Reported and Tested tags to all of our commits?
Best regards, Krzysztof
| |