lkml.org 
[lkml]   [2023]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kunit: Use gfp in kunit_alloc_resource() kernel-doc
On Thu, 16 Mar 2023 at 07:39, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Copy/pasting the code from the kernel-doc here doesn't compile because
> kunit_alloc_resource() takes a gfp flags argument. Pass the gfp
> argument from the caller to complete the example.
>
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---

Nice catch!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

> include/kunit/resource.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/resource.h b/include/kunit/resource.h
> index cf6fb8f2ac1b..c0d88b318e90 100644
> --- a/include/kunit/resource.h
> +++ b/include/kunit/resource.h
> @@ -72,7 +72,7 @@ typedef void (*kunit_resource_free_t)(struct kunit_resource *);
> * params.gfp = gfp;
> *
> * return kunit_alloc_resource(test, kunit_kmalloc_init,
> - * kunit_kmalloc_free, &params);
> + * kunit_kmalloc_free, gfp, &params);
> * }
> *
> * Resources can also be named, with lookup/removal done on a name
>
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2023-03-27 01:02    [W:0.035 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site