Messages in this thread | | | Date | Thu, 16 Mar 2023 11:02:06 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v5 06/16] perf kvm: Introduce histograms data structures |
| |
Hi Arnaldo,
On Wed, Mar 15, 2023 at 04:45:53PM -0300, Arnaldo Carvalho de Melo wrote:
[...]
> Had to add: > > > diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c > index c4cb34df155fec67..b06c11d306a11cab 100644 > --- a/tools/perf/builtin-kvm.c > +++ b/tools/perf/builtin-kvm.c > @@ -85,7 +85,6 @@ static struct kvm_event_key keys[] = { > DEF_SORT_NAME_KEY(time, mean), > { NULL, NULL } > }; > -#endif // defined(HAVE_KVM_STAT_SUPPORT) && defined(HAVE_LIBTRACEEVENT) > > struct kvm_hists { > struct hists hists; > @@ -100,6 +99,7 @@ static int kvm_hists__init(void) > perf_hpp_list__init(&kvm_hists.list); > return 0; > } > +#endif // defined(HAVE_KVM_STAT_SUPPORT) && defined(HAVE_LIBTRACEEVENT)
Thanks for fixing up, this is fine for me.
Seems to me it is not a good practice to use macros (and nested macros) to mute or unmute big chunk code. I will try to refine the building builtin-kvm.c and prepare patches based on current code base.
P.s. I saw this series has been picked up into your branch acme/tmp.perf-tools-next, if you want me to follow up anything, please let me know. Thank you!
Leo
| |