Messages in this thread | | | Subject | Re: [PATCH] net: dsa: mv88e6xxx: don't dispose of Global2 IRQ mappings from mdiobus code | From | Klaus Kudielka <> | Date | Wed, 15 Mar 2023 07:07:57 +0100 |
| |
On Tue, 2023-03-14 at 22:01 +0200, Vladimir Oltean wrote: > > I'm a bit puzzled as to how you managed to get just this one patch to > have a different subject-prefix from the others?
A long story, don't laugh at me.
I imported your patch with "git am", but I imported the "mbox" of the complete message. That was the start of the disaster.
The whole E-mail was in the commit message (also the notes before the patch), but that was easy to fix.
After git format-patch, checkpatch complained that your "From" E-mail != "Signed-off-by" E-mail. Obviously git has taken the "From" from the first E-mail header.
I looked again at your patch, there it was right, and there was also a different date (again same root cause).
So I took the shortcut: Just copy/pasted the whole patch header into the generated patch file, without thinking further -> Boom.
(a) Don't use "git am" blindly (b) Don't take shortcuts in the process
| |