lkml.org 
[lkml]   [2023]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 05/14] net/sysctl: Rename kvfree_rcu() to kvfree_rcu_mightsleep()
    Date
    From: "Uladzislau Rezki (Sony)" <urezki@gmail.com>

    The kfree_rcu() and kvfree_rcu() macros' single-argument forms are
    deprecated. Therefore switch to the new kfree_rcu_mightsleep() and
    kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use
    of the single-argument forms, which can introduce functionality bugs in
    atomic contexts and latency bugs in non-atomic contexts.

    Cc: Eric Dumazet <edumazet@google.com>
    Cc: David S. Miller <davem@davemloft.net>
    Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
    ---
    net/core/sysctl_net_core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
    index 74842b453407..782273bb93c2 100644
    --- a/net/core/sysctl_net_core.c
    +++ b/net/core/sysctl_net_core.c
    @@ -177,7 +177,7 @@ static int rps_sock_flow_sysctl(struct ctl_table *table, int write,
    if (orig_sock_table) {
    static_branch_dec(&rps_needed);
    static_branch_dec(&rfs_needed);
    - kvfree_rcu(orig_sock_table);
    + kvfree_rcu_mightsleep(orig_sock_table);
    }
    }
    }
    @@ -215,7 +215,7 @@ static int flow_limit_cpu_sysctl(struct ctl_table *table, int write,
    lockdep_is_held(&flow_limit_update_mutex));
    if (cur && !cpumask_test_cpu(i, mask)) {
    RCU_INIT_POINTER(sd->flow_limit, NULL);
    - kfree_rcu(cur);
    + kfree_rcu_mightsleep(cur);
    } else if (!cur && cpumask_test_cpu(i, mask)) {
    cur = kzalloc_node(len, GFP_KERNEL,
    cpu_to_node(i));
    --
    2.40.0.rc1.284.g88254d51c5-goog
    \
     
     \ /
      Last update: 2023-03-27 01:01    [W:4.049 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site