Messages in this thread | | | Date | Wed, 15 Mar 2023 17:46:34 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v12 2/2] mfd: max597x: Add support for MAX5970 and MAX5978 |
| |
On Tue, 07 Mar 2023, Naresh Solanki wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com> > > Implement a regulator driver with IRQ support for fault management. > Written against documentation [1] and [2] and tested on real hardware. > > Every channel has it's own regulator supply nammed 'vss1-supply' and > 'vss2-supply'. The regulator supply is used to determine the output > voltage, as the smart switch provides no output regulation. > The driver requires the 'shunt-resistor-micro-ohms' to be present in > the devicetree to properly calculate current related values. > > You must specify compatible devictree layout: > > regulator@3a { > reg = <0x3a>; > vss1-supply = <&p3v3>; > compatible = "maxim,max5978"; > > ... > > regulators { > sw0_ref: SW0 { > regulator-compatible = "SW0"; > shunt-resistor-micro-ohms = <12000>; > ... > } > } > } > > 1: https://datasheets.maximintegrated.com/en/ds/MAX5970.pdf > 2: https://datasheets.maximintegrated.com/en/ds/MAX5978.pdf > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io> > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > ... > Changes in V12: > - Use simple_mfd_i2c driver and remove previous implementation. > - Remove newline > - Use _MFD_MAX597X_H in header file > - Successfull build need following patch from regulator: > https://lore.kernel.org/r/20230216075302.68935-1-Naresh.Solanki@9elements.com > https://lore.kernel.org/r/20230210163225.1208035-1-Naresh.Solanki@9elements.com > --- > drivers/mfd/Kconfig | 10 ++++ > drivers/mfd/simple-mfd-i2c.c | 13 +++++ > include/linux/mfd/max597x.h | 96 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 119 insertions(+) > create mode 100644 include/linux/mfd/max597x.h
Applied, thanks
-- Lee Jones [李琼斯]
| |