Messages in this thread | | | From | Wei Fang <> | Subject | RE: [PATCH net-next 3/4] fec: add FIXME to move 'mac_managed_pm' to probe | Date | Wed, 15 Mar 2023 05:48:49 +0000 |
| |
Hello Wolfram,
> -----Original Message----- > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > Sent: 2023年3月14日 21:15 > To: netdev@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org; kernel@pengutronix.de; Wolfram Sang > <wsa+renesas@sang-engineering.com>; Wei Fang <wei.fang@nxp.com>; > Shenwei Wang <shenwei.wang@nxp.com>; Clark Wang > <xiaoning.wang@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; David S. > Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; > Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; > linux-kernel@vger.kernel.org > Subject: [PATCH net-next 3/4] fec: add FIXME to move 'mac_managed_pm' to > probe > > On Renesas hardware, we had issues because the above flag was set during > 'open'. It was concluded that it needs to be set during 'probe'. It looks like FEC > needs the same fix but I can't test it because I don't have the hardware. At > least, leave a note about the issue. >
Could you describe this issue in more details? So that I can reproduce and fix this issue and test it. Thanks!
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/net/ethernet/freescale/fec_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index c73e25f8995e..b16f56208d66 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -2318,6 +2318,7 @@ static int fec_enet_mii_probe(struct net_device > *ndev) > fep->link = 0; > fep->full_duplex = 0; > > + /* FIXME: should be set right after mdiobus is registered */ > phy_dev->mac_managed_pm = true; > > phy_attached_info(phy_dev); > -- > 2.30.2
| |