Messages in this thread | | | Date | Wed, 15 Mar 2023 07:43:07 +0200 | From | Matti Vaittinen <> | Subject | Re: [PATCHv2 01/12] dt-bindings: power: supply: adc-battery: add binding |
| |
On 3/15/23 00:55, Sebastian Reichel wrote: > Add binding for a battery that is only monitored via ADC > channels and simple status GPIOs. > > Signed-off-by: Sebastian Reichel <sre@kernel.org> > --- > .../bindings/power/supply/adc-battery.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/adc-battery.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/adc-battery.yaml b/Documentation/devicetree/bindings/power/supply/adc-battery.yaml > new file mode 100644 > index 000000000000..ed9702caedff > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/adc-battery.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/adc-battery.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADC battery > + > +maintainers: > + - Sebastian Reichel <sre@kernel.org> > + > +description: > + Basic battery capacity meter, which only reports basic battery data > + via ADC channels and optionally indicate that the battery is full by > + polling a GPIO line. > + > + The voltage is expected to be measured between the battery terminals > + and mandatory. The optional current/power channel is expected to > + monitor the current/power flowing out of the battery. Last but not > + least the temperature channel is supposed to measure the battery > + temperature.
This looks very good to me. Even I fell under the illusion I know what these bindings mean and how the hardware looks like ;)
I am terrible with the bindings syntax so this is not worth much but: Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Yours, -- Matti
-- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
| |