Messages in this thread | | | Date | Tue, 14 Mar 2023 07:12:52 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v1] driver core: Add CONFIG_FW_DEVLINK_SYNC_STATE_TIMEOUT |
| |
On Mon, Mar 13, 2023 at 04:27:19PM -0700, Saravana Kannan wrote: > Add a build time equivalent of fw_devlink.sync_state=timeout so that > board specific kernels could enable it and not have to deal with setting > or cluttering the kernel commandline. > > Cc: Doug Anderson <dianders@chromium.org> > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > drivers/base/Kconfig | 10 ++++++++++ > drivers/base/core.c | 5 +++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 6f04b831a5c0..da91b409482f 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -230,4 +230,14 @@ config GENERIC_ARCH_NUMA > Enable support for generic NUMA implementation. Currently, RISC-V > and ARM64 use it. > > +config FW_DEVLINK_SYNC_STATE_TIMEOUT > + bool > + default n
n is always the default, no need to say it here again.
> + help > + This is build time equivalent of adding kernel commandline parameter > + "fw_devlink.sync_state=timeout". Give up waiting on consumers and > + call sync_state() on any devices that haven't yet received their > + sync_state() calls after deferred_probe_timeout has expired or by > + late_initcall() if !CONFIG_MODULES.
I think you forgot a noun in this last sentence :)
And add something like "You should almost always want to select N here unless you have successfully tested with this command line option already"
thanks,
greg k-h
| |