Messages in this thread | | | Date | Tue, 14 Mar 2023 17:31:45 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net] net: phy: mscc: fix deadlock in phy_ethtool_{get,set}_wol() |
| |
On Tue, Mar 14, 2023 at 05:30:25PM +0200, Vladimir Oltean wrote: > Since the blamed commit, phy_ethtool_get_wol() and phy_ethtool_set_wol() > acquire phydev->lock, but the mscc phy driver implementations, > vsc85xx_wol_get() and vsc85xx_wol_set(), acquire the same lock as well, > resulting in a deadlock. > > Fixes: 2f987d486610 ("net: phy: Add locks to ethtool functions") > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Thanks Vladimir.
[Goes and checks to see if the same problem exists for other PHY drivers]
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |