Messages in this thread | | | Date | Tue, 14 Mar 2023 08:29:48 -0700 | From | Alison Schofield <> | Subject | Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase |
| |
On Tue, Mar 14, 2023 at 11:55:02AM +0700, Bagas Sanjaya wrote: > On Tue, Mar 14, 2023 at 04:43:20AM +0800, Kloudifold wrote: > > The sm750 driver had some functions named in CamelCase, > > which violates the kernel's naming convention. > > In this patch, I rename these functions to snake case, > > which is the expected style. > > > > This v2 patch was prompted by an error reported by the > > Linux test robot, which detected the compile error. > > | Reported-by: kernel test robot <lkp@intel.com> > > | Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/ > > Hi, > > I'd like to write the patch description as (ignore markdown): > > ``` > sm750 driver has sm750_hw_cursor_* functions, which are named in > camelcase. Rename them to snake case to follow the function naming > convention. > > Fixes: <commit that introduces these camelcase function> > ```
Why are you asking for a Fixes tag on this? Seems unusual for a staging driver cleanup.
Alison
> > Thanks. > > -- > An old man doll... just what I always wanted! - Clara
| |