Messages in this thread | | | Date | Tue, 14 Mar 2023 15:33:28 +0100 | Subject | Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c | From | Jan Beulich <> |
| |
On 14.03.2023 15:27, Juergen Gross wrote: > V2: > - add const, use unsigned int for loop counters (Roger Pau Monné)
Hmm, ...
> --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -1072,7 +1072,111 @@ static void end_block_io_op(struct bio *bio) > bio_put(bio); > } > > +static void blkif_get_x86_32_req(struct blkif_request *dst, > + const struct blkif_x86_32_request *src) > +{ > + unsigned int i, n;
... here you did, but ...
> +static void blkif_get_x86_64_req(struct blkif_request *dst, > + struct blkif_x86_64_request *src) > +{ > + int i, n;
... what about these?
Jan
| |