lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 1/2] gro: decrease size of CB
On Mon, Mar 13, 2023 at 9:30 AM Richard Gobert <richardbgobert@gmail.com> wrote:
>
> The GRO control block (NAPI_GRO_CB) is currently at its maximum size. This
> commit reduces its size by putting two groups of fields that are used only
> at different times into a union.
>
> Specifically, the fields frag0 and frag0_len are the fields that make up
> the frag0 optimisation mechanism, which is used during the initial parsing
> of the SKB.

Note that these fields could also be stored in some auto variable,
instead of skb.

>
> The fields last and age are used after the initial parsing, while the SKB
> is stored in the GRO list, waiting for other packets to arrive.
>
> There was one location in dev_gro_receive that modified the frag0 fields
> after setting last and age. I changed this accordingly without altering the
> code behaviour.
>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
> ---

SGTM, thanks.

Reviewed-by: Eric Dumazet <edumazet@google.com>

\
 
 \ /
  Last update: 2023-03-27 00:56    [W:0.069 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site