Messages in this thread | | | Date | Mon, 13 Mar 2023 09:50:41 +0200 | Subject | Re: [PATCHv1 07/11] power: supply: generic-adc-battery: drop memory alloc error message | From | Matti Vaittinen <> |
| |
On 3/10/23 00:50, Sebastian Reichel wrote: > Error printing happens automatically for memory allocation problems. > > Signed-off-by: Sebastian Reichel <sre@kernel.org>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> --- > drivers/power/supply/generic-adc-battery.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c > index d07eeb7d46d3..771e5cfc49c3 100644 > --- a/drivers/power/supply/generic-adc-battery.c > +++ b/drivers/power/supply/generic-adc-battery.c > @@ -243,10 +243,8 @@ static int gab_probe(struct platform_device *pdev) > bool any = false; > > adc_bat = devm_kzalloc(&pdev->dev, sizeof(*adc_bat), GFP_KERNEL); > - if (!adc_bat) { > - dev_err(&pdev->dev, "failed to allocate memory\n"); > + if (!adc_bat) > return -ENOMEM; > - } > > psy_cfg.drv_data = adc_bat; > psy_desc = &adc_bat->psy_desc;
-- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
| |