Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 13 Mar 2023 16:19:13 +0200 (EET) | From | Ilpo Järvinen <> | Subject | Re: [PATCH v9 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets |
| |
On Mon, 13 Mar 2023, Neeraj Sanjay Kale wrote:
> This adds a driver based on serdev driver for the NXP BT serial protocol > based on running H:4, which can enable the built-in Bluetooth device > inside an NXP BT chip. > > This driver has Power Save feature that will put the chip into sleep state > whenever there is no activity for 2000ms, and will be woken up when any > activity is to be initiated over UART. > > This driver enables the power save feature by default by sending the vendor > specific commands to the chip during setup. > > During setup, the driver checks if a FW is already running on the chip > by waiting for the bootloader signature, and downloads device specific FW > file into the chip over UART if bootloader signature is received.. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > --- > v2: Removed conf file support and added static data for each chip based > on compatibility devices mentioned in DT bindings. Handled potential > memory leaks and null pointer dereference issues, simplified FW download > feature, handled byte-order and few cosmetic changes. (Ilpo Järvinen, > Alok Tiwari, Hillf Danton) > v3: Added conf file support necessary to support different vendor modules, > moved .h file contents to .c, cosmetic changes. (Luiz Augusto von Dentz, > Rob Herring, Leon Romanovsky) > v4: Removed conf file support, optimized driver data, add logic to select > FW name based on chip signature (Greg KH, Ilpo Järvinen, Sherry Sun) > v5: Replaced bt_dev_info() with bt_dev_dbg(), handled user-space cmd > parsing in nxp_enqueue() in a better way. (Greg KH, Luiz Augusto von Dentz) > v6: Add support for fw-init-baudrate parameter from device tree, > modified logic to detect FW download is needed or FW is running. (Greg > KH, Sherry Sun) > v7: Renamed variables, improved FW download functions, include ps_data > into btnxpuart_dev. (Ilpo Järvinen) > v8: Move bootloader signature handling to a separate function. Add > select CRC32 to Kconfig file. (Ilpo Järvinen) > v9: Change datatype of FW download command CRC to __be32. (Ilpo Järvinen)
Thanks, looks okay to me except this one I just noticed while preparing this email:
> +MODULE_DESCRIPTION("NXP Bluetooth Serial driver v1.0 ");
I don't think version numbers belong to the module description.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-- i. | ![\](/images/icornerr.gif) |