lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v1] usb/phy add sprd ums512 usbphy
    On Mon, Mar 13, 2023 at 01:14:38AM +0800, Cixi Geng wrote:
    > From: Cixi Geng <cixi.geng1@unisoc.com>
    >
    > This driver is support USB2 phy for Spreadtrum UMS512 SOC's,
    >
    > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>

    Why is this "RFC"? What is left to do on it to be accepted?

    > ---
    > drivers/usb/phy/Kconfig | 10 +
    > drivers/usb/phy/Makefile | 1 +
    > drivers/usb/phy/phy-sprd-ums512.c | 511 ++++++++++++++++++++++++++++++
    > drivers/usb/phy/phy-sprd-ums512.h | 39 +++

    Why do you need a .h file for a single .c file? Please just put them
    all together into one file.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2023-03-27 00:55    [W:5.278 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site